Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asymmetric JWT algo support #11829

Merged
merged 10 commits into from
Dec 5, 2022
Merged

Add asymmetric JWT algo support #11829

merged 10 commits into from
Dec 5, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Nov 30, 2022 •
edited
Loading

Proposed changes:

  • Implements a new CLI option for specifying JWT private key required to add support for asymmetric algorithms.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review December 1, 2022 18:34
@ancalita ancalita requested a review from a team as a code owner December 1, 2022 18:34
@ancalita ancalita requested review from m-vdb and znat December 5, 2022 10:07
znat
znat suggested changes Dec 5, 2022
View reviewed changes
tests/test_server.py Outdated Show resolved Hide resolved
docs/docs/http-api.mdx Outdated Show resolved Hide resolved
@znat
Copy link
Contributor

znat commented Dec 5, 2022

Also, is this based on 3.2.x on purpose?

m-vdb
m-vdb approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

docs/docs/http-api.mdx Outdated Show resolved Hide resolved
@ancalita
Copy link
Member Author

ancalita commented Dec 5, 2022

Also, is this based on 3.2.x on purpose?

@znat Yes, based on the Jira thread, this was requested in a 3.2.x micro, I'll port it to 3.3.x too once this gets approved.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

🚀 A preview of the docs have been deployed at the following URL: https://11829--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb merged commit 9f09614 into 3.2.x Dec 5, 2022
@m-vdb m-vdb deleted the ATO-568-using-asymmetric-algorithms-jwt branch December 5, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

@znat znat znat approved these changes

@radovanZRasa radovanZRasa Awaiting requested review from radovanZRasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ancalita @znat @m-vdb