Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Except validate_form_action from selective_domain #12189

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Mar 28, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt requested a review from a team as a code owner March 28, 2023 11:49
docs/docs/domain.mdx Outdated Show resolved Hide resolved
@Tawakalt Tawakalt force-pushed the ATO-785-selectv-dom-val-form-action branch from 5780acf to 72bc9cf Compare March 28, 2023 15:29
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@@ -809,13 +809,16 @@ action_endpoint:
```
**After selective domain for custom actions is enabled, domain will be sent only to
those custom actions which have specifically stated that they need it.**
Custom actions inheriting from rasa-sdk [FormValidationAction](https://rasa.com/docs/rasa/action-server/validation-action/#formvalidationaction-class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use dynamic reference instead:

Suggested change
Custom actions inheriting from rasa-sdk [FormValidationAction](https://rasa.com/docs/rasa/action-server/validation-action/#formvalidationaction-class)
Custom actions inheriting from rasa-sdk [FormValidationAction](./action-server/validation-action.mdx#formvalidationaction-class)

@Tawakalt Tawakalt force-pushed the ATO-785-selectv-dom-val-form-action branch from c645e16 to eaf1166 Compare March 29, 2023 07:55
@Tawakalt Tawakalt enabled auto-merge March 29, 2023 11:38
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12189--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Tawakalt Tawakalt merged commit 5312929 into 3.5.x Mar 29, 2023
@Tawakalt Tawakalt deleted the ATO-785-selectv-dom-val-form-action branch March 29, 2023 12:37
Tawakalt added a commit that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants