Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-882 Appending assistant id truncates comments #12286

Merged
merged 8 commits into from
Apr 19, 2023

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Apr 18, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt requested a review from a team as a code owner April 18, 2023 12:29
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 💯 Left a few tiny suggestions for the unit test.

rasa/shared/utils/io.py Outdated Show resolved Hide resolved
tests/cli/test_utils.py Show resolved Hide resolved
tests/cli/test_utils.py Outdated Show resolved Hide resolved
tests/cli/test_utils.py Show resolved Hide resolved
@Tawakalt Tawakalt requested a review from ancalita April 18, 2023 13:23
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Tawakalt Tawakalt enabled auto-merge April 19, 2023 07:58
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12286--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Tawakalt Tawakalt merged commit a9b6671 into 3.5.x Apr 19, 2023
@Tawakalt Tawakalt deleted the ATO-882-appending-assistant-id-truncates-comments branch April 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants