Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rasa test should use TrainingDataImporter #5986

Closed
1 task
wochinge opened this issue Jun 10, 2020 · 3 comments · Fixed by #7674 or #7795
Closed
1 task

rasa test should use TrainingDataImporter #5986

wochinge opened this issue Jun 10, 2020 · 3 comments · Fixed by #7674 or #7795
Assignees
@Imod7
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Jun 10, 2020 •
edited
Loading

Current State
When running rasa train it uses the TrainingDataImporter interface to load and provide data to the underlying functions.
rasa test doesn't use this interface and calls this directly.

Solution
Whenever we import training data we should use the TrainingDataImporter interface.

Todo:

  • Make sure rasa test uses the TrainingDataImporter (I believe here and here
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework priority:low labels Jun 10, 2020
@kevinthenet
Copy link
Contributor

I was just going to make this same issue!

@kevinthenet kevinthenet mentioned this issue Aug 31, 2020
Closed
@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 11, 2020
@stale stale bot removed the stale label Dec 1, 2020
@Imod7 Imod7 mentioned this issue Jan 3, 2021
Merged
@Imod7 Imod7 linked a pull request Jan 4, 2021 that will close this issue
Implementing the use of TrainingDataImporter in rasa test #7674
Merged
@wochinge
Copy link
Contributor Author

wochinge commented Jan 8, 2021 •
edited
Loading

@Imod7 I'll re-open this as the Core part is still missing. Unassigning you though - if you want to complete it you're welcome. Otherwise I'd suggest to finish your Rasa X issue first.

@wochinge wochinge reopened this Jan 8, 2021
@Imod7 Imod7 self-assigned this Jan 18, 2021
@Imod7 Imod7 mentioned this issue Jan 20, 2021
Closed
This was linked to pull requests Jan 20, 2021
Using the TrainingDataImporter to load the data in core test #7758
Closed
Loading the data in core test with TrainingDataImporter interface #7795
Merged
@Imod7 Imod7 mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Imod7 Imod7

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
3 participants
@wochinge @Imod7 @kevinthenet