Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump custom strings in rasa shell with ensure_ascii=false #9386

Merged
merged 8 commits into from
Apr 19, 2022
Merged

dump custom strings in rasa shell with ensure_ascii=false #9386

merged 8 commits into from
Apr 19, 2022

Conversation

goxiaoy
Copy link
Contributor

@goxiaoy goxiaoy commented Aug 18, 2021 •
edited

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@goxiaoy goxiaoy requested a review from a team as a code owner August 18, 2021 06:14
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

twerkmeister
twerkmeister approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot for filing the PR :) Unfortunately, these things keep sneaking in and it's difficult to notice if you only use latin script.

wochinge
wochinge reviewed Aug 19, 2021
View reviewed changes
changelog/9386.bugfix.md Outdated Show resolved Hide resolved
rasa/core/channels/console.py Outdated Show resolved Hide resolved
rasa/core/channels/console.py Outdated Show resolved Hide resolved
goxiaoy and others added 3 commits August 20, 2021 00:49
@goxiaoy @wochinge
Update changelog/9386.bugfix.md
5d27833 
Co-authored-by: Tobias Wochinger <mail@tobias-wochinger.de>
@goxiaoy @wochinge
Update rasa/core/channels/console.py
3dbb288 
Co-authored-by: Tobias Wochinger <mail@tobias-wochinger.de>
@goxiaoy @wochinge
Update rasa/core/channels/console.py
18c888c 
Co-authored-by: Tobias Wochinger <mail@tobias-wochinger.de>
@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot removed the stale label Apr 19, 2022
ancalita
ancalita reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve and merge as soon as the code quality check gets fixed by removing duplicate import.

rasa/core/channels/console.py Outdated Show resolved Hide resolved
@ancalita ancalita merged commit e0e1e38 into RasaHQ:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge left review comments

@twerkmeister twerkmeister twerkmeister approved these changes

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goxiaoy @CLAassistant @twerkmeister @wochinge @ancalita