Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup #304

Merged
merged 2 commits into from
Dec 17, 2017
Merged

Update setup #304

merged 2 commits into from
Dec 17, 2017

Conversation

ColCarroll
Copy link
Contributor

Description

This adds all the requirements to run the project into the setup.py. It seems unlikely this gets installed without separately installing numpy, scipy, etc, but still good practice! I am not a conda expert, but it might also be best to change the travis setup to just make a clean environment, then run pip install ., so that the requirements truly only need to be specified in one place.

Related issues or pull requests

Discussed in #302.

Pull Request requirements

  • Added appropriate unit test functions in the ./mlxtend/*/tests directories
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass
  • Checked the test coverage by running nosetests ./mlxtend --with-coverage
  • Checked for style issues by running flake8 ./mlxtend
  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file
  • Modify documentation in the appropriate location under mlxtend/docs/sources/ (optional)
  • Checked that the Travis-CI build passed at https://travis-ci.org/rasbt/mlxtend

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.967% when pulling dcb332f on ColCarroll:update_setup into c1100c9 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Dec 17, 2017

Thanks again, that's a pretty good solution to keep the requirements.txt and setup.py in sync! Good idea also regarding the travis installs. I will make a new issue as a reminder to take a look at this! Thanks!

@rasbt rasbt merged commit 21ff16a into rasbt:master Dec 17, 2017
@ColCarroll
Copy link
Contributor Author

thanks for the useful project, doctor!

@ColCarroll ColCarroll deleted the update_setup branch December 17, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants