SoftmaxRegression is not cloneable

[vanoudh]

from sklearn.base import clone
from mlxtend.classifier import SoftmaxRegression

clf = SoftmaxRegression()
clfc = clone(clf)

-> "it does not seem to be a scikit-learn estimator as it does not implement a 'get_params' methods."

It seems that just deriving from BaseEstimator solves the issue but I am not sure.

[jrbourbeau]

@vanoudh I was able to reproduce this error with the current master branch. I checked and you're correct, having SoftmaxRegression inherit from BaseEstimator does fix the cloning problem. Are you interested in opening a PR?

[jrbourbeau]

So it's documented somewhere, it looks like there are a few other estimators that also don't inherit from BaseEstimator:

Classifiers:

• SoftmaxRegression
• LogisticRegression
• Adaline
• MultiLayerPerceptron
• Perceptron

Regressors:

• LinearRegression

[rasbt]

Thanks for the head-up, will fix that!

[vanoudh]

Thanks a lot.

[rasbt]

So it's documented somewhere, it looks like there are a few other estimators that also don't inherit from BaseEstimator:

Thanks for the list, @jrbourbeau . I updated the existing _BaseEstimator with the necessary functions to make them all compatible

[rasbt]

Should be fixed now :)