Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow estimators to be cloned #374

Merged
merged 4 commits into from
Apr 25, 2018
Merged

Allow estimators to be cloned #374

merged 4 commits into from
Apr 25, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Apr 24, 2018

Description

Adds get_params and set_params methods so that mlxtend estimators can be cloned via scikit-learn's clone function.

Related issues or pull requests

Fixes #372

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Apr 24, 2018

Hello @rasbt! Thanks for updating the PR.

Line 173:80: E501 line too long (80 > 79 characters)

Comment last updated on April 25, 2018 at 02:41 Hours UTC

@coveralls
Copy link

coveralls commented Apr 24, 2018

Coverage Status

Coverage decreased (-1.0%) to 90.909% when pulling 27efc5e on getparams into 6313cd1 on master.

@rasbt rasbt changed the title Allow estimators to be cloned Allow estimators to be cloned [WIP] Apr 25, 2018
@rasbt rasbt changed the title Allow estimators to be cloned [WIP] Allow estimators to be cloned Apr 25, 2018
@rasbt rasbt merged commit c2e56fe into master Apr 25, 2018
@rasbt rasbt deleted the getparams branch May 12, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants