Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Documentation about Support for Association Rules #849

Closed
BrunoBarre opened this issue Sep 15, 2021 · 1 comment · Fixed by #1003
Closed

Incorrect Documentation about Support for Association Rules #849

BrunoBarre opened this issue Sep 15, 2021 · 1 comment · Fixed by #1003

Comments

@BrunoBarre
Copy link

BrunoBarre commented Sep 15, 2021

Hello,

There seems to be an incoherence in the support metric description for association rules in this page http://rasbt.github.io/mlxtend/user_guide/frequent_patterns/association_rules/#example-3-frequent-itemsets-with-incomplete-antecedent-and-consequent-information.

The formula is correct : support(A→C)=support(A∪C),range: [0,1]. But in the following paragraph, it is written The 'support' metric then computes the support of the combined itemset A ∪ C -- note that 'support' depends on 'antecedent support' and 'consequent support' via min('antecedent support', 'consequent support'). Which is clearly different from the formula.

In mlxtend.frequent_patterns.association_rules support is computed using the formula, and not the minimum between the antecedent support and consequent support.

@zuari1993
Copy link
Contributor

Hi,
Thanks for pointing this out.
You are correct on the inconsistency.
I will work on fixing this.

zuari1993 added a commit to zuari1993/mlxtend that referenced this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants