-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to nanmean instead of mean #211
Conversation
Moving to nanmean allows the use of scorers that return nan without breaking existing functionality
Hello @mrkaiser! Thanks for updating the PR.
Comment last updated on July 07, 2017 at 14:24 Hours UTC |
The build is failing due to an issue with |
Thanks for the PR, and sorry about the issues with travis-ci -- I never had any issues with that and it worked up to last weekend. Hm, maybe they changed sth this week. I will look into that and let you know when it's resolved. |
Not sure why this issue occurred. I send in a PR for testing and it worked fine. Maybe, it was a temporary issue with the "trusty" environments on their side -- they changed something last week according to their blog. In any case, I removed the trusty flag (I think it was needed back then for the tensorflow code), and it should work fine now. Could you try again? (maybe with a tiny edit like a whitespace or sth like that and change it back). PS: The PR looks great so far, thanks! |
@rasbt I have updated the builds and all checks are passing |
That's awesome, thanks for the PR! |
Moving to nanmean allows the use of scorers that return nan without breaking existing functionality
Description
Moved the means to
np.nanmean
to support scorers that may implement returningRelated issues or pull requests
Link related issues/pull requests here
Pull Request requirements
./mlxtend/*/tests
directoriesnosetests ./mlxtend -sv
and make sure that all unit tests passnosetests ./mlxtend --with-coverage
flake8 ./mlxtend
./docs/sources/CHANGELOG.md
filemlxtend/docs/sources/
(optional)