Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements #371

Merged
merged 3 commits into from
Apr 21, 2018
Merged

Doc improvements #371

merged 3 commits into from
Apr 21, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Apr 21, 2018

Description

Improvements to the docs, including links to the User Guides in the API docs

Related issues or pull requests

Addresses #364 (the online version of the docs will be updated upon the next mlxtend release)

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

Hello @rasbt! Thanks for submitting the PR.

Line 19:80: E501 line too long (80 > 79 characters)

Line 410:80: E501 line too long (84 > 79 characters)
Line 422:80: E501 line too long (81 > 79 characters)

Line 35:80: E501 line too long (80 > 79 characters)
Line 36:80: E501 line too long (81 > 79 characters)

Line 61:80: E501 line too long (80 > 79 characters)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.891% when pulling 04be1dd on doc-improvements into 41a5f99 on master.

@rasbt rasbt merged commit 36cca49 into master Apr 21, 2018
@rasbt rasbt deleted the doc-improvements branch May 12, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants