Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sfs cv generator message #377

Merged
merged 3 commits into from
Apr 27, 2018

Conversation

jrbourbeau
Copy link
Contributor

@jrbourbeau jrbourbeau commented Apr 26, 2018

Description

This PR adds a meaningful error message when a cross-validation generator is input to SequentialFeatureSelector

Related issues or pull requests

Fixes #373

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

coveralls commented Apr 26, 2018

Coverage Status

Coverage increased (+0.02%) to 90.924% when pulling 0511056 on jrbourbeau:add_sfs_cv_generator_message into 0f02c0d on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Apr 27, 2018

That looks great, thanks a lot!

@rasbt rasbt merged commit 2ced0d4 into rasbt:master Apr 27, 2018
@jrbourbeau jrbourbeau deleted the add_sfs_cv_generator_message branch April 27, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants