tested efficient sparse apriori version #329

[DanielMorales9]

Description

Improved memory efficiency for apriori algorithm when SparseDataFrame is passed as a input

Related issues or pull requests

#329

[pep8speaks]

Hello @DanielMorales9! Thanks for updating the PR.

• In the file mlxtend/frequent_patterns/tests/test_apriori.py, following are the PEP8 issues :

Line 77:12: E127 continuation line over-indented for visual indent
Line 80:12: E127 continuation line over-indented for visual indent
Line 94:16: E127 continuation line over-indented for visual indent
Line 97:16: E127 continuation line over-indented for visual indent

Comment last updated on July 02, 2018 at 16:45 Hours UTC

[coveralls]

Coverage increased (+0.03%) to 91.358% when pulling 8d3aba4 on DanielMorales9:master into 470224e on rasbt:master.

[rasbt]

That's awesome, thanks a lot for the PR!

• Could you remove the pytest cache directory ( .pytest_cache/v/cache/nodeids) from the commit? (please feel free to add .pytest_cache/ to the gitignore file)
• Add a short note to the changelog file
• Change df : pandas DataFrame to df : pandas DataFrame or SparseDataFrame in the docstring

That would be awesome

[rasbt]

THat's great, thx a lot!

[jaksmid]

I am sorry that I am a bit late to the conversation but regarding the PR, what is the added benefit of the PR compared to the sparse example that is already on the MLxtend page?
http://rasbt.github.io/mlxtend/user_guide/frequent_patterns/apriori/#example-3-sparse-representation

The MLxtend already supported the sparse dataframes in the apriori.py.

[DanielMorales9]

It was not memory efficient

[jaksmid]

Sorry, my bad, I didn't notice that the SparseDataframe was transformed to non sparse values.
Disregard my comment then.