Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomholdoutsplit #442

Merged
merged 5 commits into from
Sep 24, 2018
Merged

randomholdoutsplit #442

merged 5 commits into from
Sep 24, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Sep 24, 2018

Description

Adds a RandomHoldoutSplit class to perform a train/valid split without rotation in SequentialFeatureSelector, scikit-learn GridSearchCV etc.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

Hello @rasbt! Thanks for updating the PR.

@coveralls
Copy link

coveralls commented Sep 24, 2018

Coverage Status

Coverage increased (+0.2%) to 91.295% when pulling b0804b0 on randomholdoutsplit into 030c1b7 on master.

@rasbt rasbt merged commit e215318 into master Sep 24, 2018
@rasbt rasbt deleted the randomholdoutsplit branch November 10, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants