Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PredefinedHoldoutSplit #443

Merged
merged 4 commits into from
Sep 24, 2018
Merged

PredefinedHoldoutSplit #443

merged 4 commits into from
Sep 24, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Sep 24, 2018

Description

Adds a PredefinedHoldoutSplit class to perform a train/valid split, based on user-specified indices, without rotation in SequentialFeatureSelector, GridSearchCV, etc.

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Sep 24, 2018

Hello @rasbt! Thanks for updating the PR.

Comment last updated on September 24, 2018 at 08:02 Hours UTC

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.798% when pulling 8ab8a1f on predefinedsplit into e215318 on master.

@rasbt rasbt merged commit 13b4df6 into master Sep 24, 2018
@rasbt rasbt deleted the predefinedsplit branch November 10, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants