Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined f test 5x2cv #461

Merged
merged 2 commits into from
Nov 8, 2018
Merged

combined f test 5x2cv #461

merged 2 commits into from
Nov 8, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Nov 8, 2018

Description

Add a combined F-test 5x2cv function to compare the performance of 2 models.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Nov 8, 2018

Hello @rasbt! Thanks for updating the PR.

Line 30:1: E303 too many blank lines (3)

Comment last updated on November 08, 2018 at 04:31 Hours UTC

@rasbt rasbt merged commit 403f395 into master Nov 8, 2018
@rasbt rasbt deleted the combined-f branch November 10, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants