Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitening parameter for PCA #475

Merged
merged 2 commits into from
Dec 1, 2018
Merged

Whitening parameter for PCA #475

merged 2 commits into from
Dec 1, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Dec 1, 2018

Description

Adds a whitening parameter to PrincipalComponentAnalysis, to optionally whiten the transformed data such that the features have unit variance.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Dec 1, 2018

Hello @rasbt! Thanks for updating the PR.

Comment last updated on December 01, 2018 at 21:02 Hours UTC

@coveralls
Copy link

coveralls commented Dec 1, 2018

Coverage Status

Coverage increased (+0.03%) to 91.829% when pulling 848d139 on pca-whitening into c9c949b on master.

@rasbt rasbt merged commit a4bcab8 into master Dec 1, 2018
@rasbt rasbt deleted the pca-whitening branch June 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants