Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise apriori SparseDataFrame ValueError #503

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Raise apriori SparseDataFrame ValueError #503

merged 2 commits into from
Feb 11, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Feb 11, 2019

Description

Raises a more informative error if a SparseDataFrame is passed to apriori and the dataframe has integer column names that don't start with 0 due to current limitations of the SparseDataFrame implementation in pandas.

Related issues or pull requests

Fixes #501

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Feb 11, 2019

Hello @rasbt! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 11, 2019 at 15:22 Hours UTC

@coveralls
Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage decreased (-0.003%) to 91.596% when pulling 8d0a84a on apriori-warning into 3caa906 on master.

@rasbt rasbt merged commit cce9e60 into master Feb 11, 2019
@rasbt rasbt deleted the apriori-warning branch June 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants