Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce n_jobs to StackingCVRegressor #512

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Conversation

qiagu
Copy link
Contributor

@qiagu qiagu commented Mar 14, 2019

Description

Use the sklearn born cross_val_predict to replace the explicit cv splitting loop.
Add arguments n_jobs and pre_dispatch to be able to take advantage of parallel computation.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

coveralls commented Mar 15, 2019

Coverage Status

Coverage decreased (-0.002%) to 91.615% when pulling 866aff3 on qiagu:stackingcv into 8536994 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Mar 15, 2019

That's nice, thanks for this!

@rasbt rasbt merged commit 5016a00 into rasbt:master Mar 15, 2019
@qiagu
Copy link
Contributor Author

qiagu commented Mar 15, 2019

@rasbt Thanks for merging. I am trying to make stacking ensemble machine learning available on Galaxy. Luckily, I found this great library.

@rasbt
Copy link
Owner

rasbt commented Mar 15, 2019

Nice, haven't heard of Galaxy before but looks cool! Glad to hear this implemenation turned out to be useful for incorporating there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants