-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stacking estimators capable of replacing base estimator in searchcv #522
Conversation
Sorry, the |
@rasbt I didn't figure out how to update the docs under the |
Looks amazing! Thanks a lot! It's a bit unfortunate that the safe-indexing has to go, but yeah, multiprocessing is probably the more useful one here. Regarding the API modules, all you need to do is to
I am happy to do that if it doesn't work. |
It worked. Thank you. @rasbt |
Awesome, thanks! Looks got to merge to me, unless you have anything else in mind that should be added.
thanks :). Haha, I remember that it took me quite some time to get that one working properly :) |
The |
Alright, will merge then. Again, thanks a lot for this very nice PR! |
Description
StackingCVClassifier
_BaseXComposition
toStackingCVClassifier
_BaseXComposition
toStackingClassifier
_BaseXComposition
toStackingRegressor
Related issues or pull requests
#517
Make Stacking classes capable of replacing regressors/classifiers in GridSearchCV
Fixes #517
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)nosetests ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend