Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix, feature_importance_permutation can now accept functions as metric argument #528

Merged
merged 1 commit into from
May 10, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented May 10, 2019

Description

Fixes #526

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.572% when pulling ab920e4 on fix-feat-imp into ec2658c on master.

@rasbt rasbt merged commit f790243 into master May 10, 2019
@rasbt rasbt deleted the fix-feat-imp branch September 15, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature_importance_permutation breaks
2 participants