Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop_last_proba feature for stacking classifiers #532

Merged
merged 2 commits into from
May 12, 2019
Merged

drop_last_proba feature for stacking classifiers #532

merged 2 commits into from
May 12, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented May 12, 2019

Description

Adds a parameter to StackingClassifier and StackingCVClassifier to optionally drop one of the probability columns of the 1st-level classifiers to avoid collinearity.

Related issues or pull requests

Fixes #527

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented May 12, 2019

Hello @rasbt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-12 04:45:59 UTC

@coveralls
Copy link

coveralls commented May 12, 2019

Coverage Status

Coverage increased (+0.04%) to 91.62% when pulling caa9c71 on drop-proba into 8a03d0c on master.

@rasbt rasbt merged commit 1284e06 into master May 12, 2019
@rasbt rasbt deleted the drop-proba branch September 15, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop last proba column in StackingClassifier and StackingCVClassifier
3 participants