Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixed feature set support to SFS #578

Merged
merged 1 commit into from
Aug 20, 2019
Merged

add fixed feature set support to SFS #578

merged 1 commit into from
Aug 20, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Aug 20, 2019

Description

Adds a new fixed_features parameter to SFS for features to be forced to be included in the results.

Related issues or pull requests

#558

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 92.35% when pulling cd5e660 on fixed-features into 936a96a on master.

@gosuto-inzasheru
Copy link

This parameter is not yet mentioned in the documentation at http://rasbt.github.io/mlxtend/user_guide/feature_selection/SequentialFeatureSelector/

@rasbt
Copy link
Owner Author

rasbt commented Oct 15, 2019

That's because it's currently only in the development branch (v 0.18.0dev) The latest release version os 0.17.0. The documentation will be updated automatically once 0.18.0dev is changed to 0.18.0 and uploaded to PyPI

@rasbt rasbt mentioned this pull request Jan 29, 2020
@rasbt rasbt deleted the fixed-features branch September 15, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants