Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dof in svd-mode PCA to n-1 #595

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Change dof in svd-mode PCA to n-1 #595

merged 4 commits into from
Sep 24, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Sep 24, 2019

Description

The svd mode of mlxtend.feature_extraction.PrincipalComponentAnalysis now also n-1 degrees of freedom instead of n d.o.f. when computing the eigenvalues to match the behavior of eigen.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 92.33% when pulling 9465077 on pca-ddof into e2f7e07 on master.

@rasbt rasbt merged commit bb95d13 into master Sep 24, 2019
@rasbt rasbt mentioned this pull request Jan 29, 2020
@rasbt rasbt deleted the pca-ddof branch September 15, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants