Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug 690, where fpmax returned incorrect support values #692

Merged
merged 2 commits into from
May 20, 2020

Conversation

harenbergsd
Copy link
Contributor

@harenbergsd harenbergsd commented May 17, 2020

Description

Fixes #690

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@rasbt
Copy link
Owner

rasbt commented May 20, 2020

Thanks @harenbergsd , that looks like a pretty efficient fix :)

@harenbergsd
Copy link
Contributor Author

Thanks @harenbergsd , that looks like a pretty efficient fix :)

Thanks, I'll pretend like I hadn't had something similar to this before and broke it with a different commit :)

@rasbt rasbt merged commit 56944fc into rasbt:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fpmax gives wrong support
2 participants