Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras Sequential Model Support for Bias Variance Computation #725

Merged
merged 4 commits into from
Sep 11, 2020

Conversation

hanzigs
Copy link
Contributor

@hanzigs hanzigs commented Sep 4, 2020

Description

@pep8speaks
Copy link

pep8speaks commented Sep 4, 2020

Hello @hanzigs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-11 17:22:03 UTC

@coveralls
Copy link

coveralls commented Sep 4, 2020

Coverage Status

Coverage decreased (-0.02%) to 90.661% when pulling 81e7a87 on hanzigs:master into 8eb6954 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Sep 11, 2020

Thanks, @hanzigs, this looks great. Ideally, we could add a unit test, but this would add yet another dependency to the package, so I think it's fine leaving it like this. Will merge shortly. Thanks!

@rasbt rasbt merged commit a6ff5b8 into rasbt:master Sep 11, 2020
@hanzigs
Copy link
Contributor Author

hanzigs commented Sep 11, 2020

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants