Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify fit_params docs for SFS #732

Merged
merged 2 commits into from Sep 29, 2020
Merged

Clarify fit_params docs for SFS #732

merged 2 commits into from Sep 29, 2020

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Sep 29, 2020

Clarifies the use of fit_params in SFS docstring as discussed on the mailing list at https://groups.google.com/g/mlxtend/c/Xn3FWaVzLTc/m/qXPlq3GHCAAJ

@pep8speaks
Copy link

pep8speaks commented Sep 29, 2020 •
edited

Hello @rasbt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-29 17:34:07 UTC

@rasbt rasbt merged commit 770ddab into master Sep 29, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.739% when pulling b104486 on sfsdoc into e74e61b on master.

@rasbt rasbt deleted the sfsdoc branch November 12, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasbt @pep8speaks @coveralls