Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed table layout for McNemar's test #744

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Conversation

mmarius
Copy link

@mmarius mmarius commented Nov 2, 2020

Description

Fixing the table layout for McNemar's test and changed corresponding unit tests accordingly.

Related issues or pull requests

Fixes #664

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage decreased (-0.1%) to 90.66% when pulling 8c82cf6 on mmarius:issue#664 into 71942e1 on rasbt:master.

@rasbt rasbt merged commit 276fdd3 into rasbt:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

McNemar's test mcnemar_table off diagonal entries are swapped
3 participants