New Feature: Scatter Histogram

[Maitreyee1]

Code of Conduct

Description

Added jointplot to display scatterplot of features and subplot of histograms of individual features along the axes.

Related issues or pull requests

(#596)

Pull Request Checklist

• Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
• Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
• Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
• Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
• Checked for style issues by running flake8 ./mlxtend

[pep8speaks]

Hello @Maitreyee1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file mlxtend/plotting/scatter_hist.py:

Line 61:5: E303 too many blank lines (2)
Line 76:47: W291 trailing whitespace

Comment last updated at 2021-01-23 20:32:23 UTC

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[coveralls]

Coverage increased (+0.03%) to 90.688% when pulling abd0571 on Maitreyee1:master into e5c906f on rasbt:master.

[rasbt]

Thanks a lot for the PR, I really appreciate it that you are putting time into this. Unfortunately, I'd prefer not adding additional libraries (like seaborn) to the dependency list. Is it possible to achieve the same with base matptlotlib?

[Maitreyee1]

hey @rasbt ! Thanks a lot for reviewing! I understand. I will try with matplotlib.

[Maitreyee1]

Hey @rasbt , I changed the scatter histogram implementation from seaborn to matplotlib. Would be great if you could have a look.

[rasbt]

I am so sorry. I am just catching up with email notifications after the really busy end of last semester and just realized that I totally missed your PR! I will review it soon in the next few days! :)

[rasbt]

I just got a chance to spend some more time with your PR. The function looked really nice, I like the clean design! I just made a little change to the input arguments so that is closer to the matplotlib API, i.e., accepting x and y arguments as data arrays or pandas series. Let me know if you have additional suggestions.

[Maitreyee1]

Hey, @rasbt thank you so much for taking the time and reviewing my PR. I do not have any additional suggestions. It looks great!

[rasbt]

Thanks for confirming. My apologies, I recently figured out that somehow email notification haven not been getting through to me via GitHub. Switching email addresses for notifications seems to solve that now but I missed lots of old notifications. Anyways, happy to merge :)

[Maitreyee1]

Hey! @rasbt No worries at all. Thank you so much for the merge! Looking forward to contributing more!👍