Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contour kwargs to plot_decision_regions. #881

Merged
merged 9 commits into from
Jan 19, 2022
Merged

Conversation

pbloem
Copy link
Contributor

@pbloem pbloem commented Jan 18, 2022

Code of Conduct

Check.

Description

I added a kwargs keyword to control how the lines between decision regions look. I needed this for a thing, so I thought I'd make it a pull request. I think I followed the logic of the other two kwargs arguments correctly.

Related issues or pull requests

None

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • [+] Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • [+] Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Jan 18, 2022

Hello @pbloem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-19 16:46:51 UTC

@rasbt
Copy link
Owner

rasbt commented Jan 19, 2022

Great, thanks! I don't think we'll need a doc example for that, so it should be good to merge.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rasbt rasbt merged commit 5a14e37 into rasbt:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants