Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in InsertTag function. #9

Closed
huangshishu opened this issue Nov 25, 2013 · 2 comments
Closed

A bug in InsertTag function. #9

huangshishu opened this issue Nov 25, 2013 · 2 comments

Comments

@huangshishu
Copy link

In function InsertTag, here at line: if( preg_match( $words[ 0 ], $x ) ).

I think it should be preg_match( $words[ 0 ], $x ) => preg_match( $x, $words[ 0 ] ).
@rashid2538
Copy link
Owner

@huangshishu I've fixed and updated the code, please check and gimme your feedback.

@gondo
Copy link
Contributor

gondo commented Jan 23, 2014

already fixed, close this issue pls

mkalkbrenner pushed a commit to mkalkbrenner/php-htmldiff that referenced this issue Mar 3, 2015
@mgersten-caxy
Merge pull request rashid2538#9 from caxy/fix-empty_del_and_ins_tags
144c621 
Check for empty oldText or newText before processing del or ins in processReplaceOperation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rashid2538 @gondo @huangshishu