Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcgencmd documentation #1065

Closed
JamesH65 opened this issue Jan 15, 2019 · 14 comments
Closed

vcgencmd documentation #1065

JamesH65 opened this issue Jan 15, 2019 · 14 comments
Assignees

Comments

@JamesH65
Copy link
Contributor

There don't appear to be any pages dedicated to the vcgencmd helper application, which is often referred in the forums or when trying to help users with issues.

@JamesH65 JamesH65 self-assigned this Jan 15, 2019
@ghost
Copy link

ghost commented Jan 15, 2019

Quite a simple command. Is it open source? I think the first step should be adding basic usage info to the binary.

@JamesH65
Copy link
Contributor Author

https://github.com/raspberrypi/userland/blob/master/host_applications/linux/apps/gencmd/gencmd.c

But most of the heavy lifting is done on the other side of the link to the videocore, as you might expect! There is scope for adding help information to the ARM end, but the list of commands is sent back from the VC, so when new commands are added they might get missed from adding to the help at this end.

@ghost
Copy link

ghost commented Jan 15, 2019

You will of course have exactly the same problem with any documentation for this command - namely it needs to be updated whenever a new videocore command is added.

@ghost
Copy link

ghost commented Jan 15, 2019

See the elinux wiki for a starting point for some docs: https://elinux.org/RPI_vcgencmd_usage

@JamesH65
Copy link
Contributor Author

Thanks. First draft at docs (actually including vcbdg) on https://github.com/raspberrypi/documentation/tree/JamesH65-patch-vcgencmd-vcdbg-docs

@jriwanek
Copy link
Contributor

Just incase you miss the comment on the commit, the list of supported codecs for codec_enabled on the branch is inaccurate, there's loads more:
https://github.com/jriwanek/RaspberryPi/wiki/Codecs

@ghost
Copy link

ghost commented Jan 17, 2019

Interesting - hardware support for animated GIFs. I suppose that's to be expected given the target market at the time the VC4 was developed.

Some review comments on the vcgencmd page in development:

Displays the supported and deected state of the official camera

Doesn't explain what 'supported' means. Suggest:

Displays whether the current firmware supports the camera module, and whether the VideoCore has detected that a camera module is currently attached.

(Wording not perfect but you can probably leave that to a copy-editor).

Also, for get_throttled - replace 'under-voltage' with 'under-voltage detected'.

For 'get_lcd_info' it would be worth noting which displays this refers to - HDMI is one of them as my current Pi is returning '1920 1080 24' and only has an HDMI-connected display attached.

@JamesH65
Copy link
Contributor Author

Thanks, updated.

@ghost
Copy link

ghost commented Feb 22, 2019

I'm not sure adding the documentation for the vc... commands under Raspbian is right. These utilities can be used on other distros. I would expect the Raspbian section of the docs to be used for Raspbian-specific stuff. The best fit out of the existing documentation categories is probably "Hardware".

I've made my changes to the vcgencmd binary dependent on this documentation landing, since my changes to the binary don't actually do anything particularly useful on their own. I've added the proposed URL for the vcgencmd documentation to the usage.

@JamesH65
Copy link
Contributor Author

There's a problem here that the categories we currently have don't really reflect what I'd like to add in some cases. Really need to assess that but because of the first page being different to the rest of the repo (pretty graphics), its a bit awkward to change. Will look in to it.

@ghost
Copy link

ghost commented Feb 25, 2019

Perhaps that's an issue to add to the wider review of the website which seems to be underway.

@ghost
Copy link

ghost commented Feb 25, 2019

I've thought about this a bit, and I think the best way forward is probably just to add the docs for vcgencmd et al to the existing 'Raspbian' category, then leave any reorganisation of the docs to a future task. (I'm also not entirely sure how much of the various utilities the other distributions are using).

@bennuttall
Copy link
Contributor

Agreed

@lurch
Copy link
Contributor

lurch commented Dec 9, 2019

Closed by #1077

@lurch lurch closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants