Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings on building the documentation site #2825

Open
aallan opened this issue Mar 2, 2023 · 8 comments
Open

Deprecation warnings on building the documentation site #2825

aallan opened this issue Mar 2, 2023 · 8 comments
Assignees
Labels
backlog We'll be getting to it eventually bug dependencies Pull requests that update a dependency file toolchain This is an infrastructure/toolchain issue

Comments

@aallan
Copy link
Contributor

aallan commented Mar 2, 2023

After the PRs for dependency updates that @mudge merged the other day I’m now getting deprecation warnings on building the documentation site.

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
40 │   margin-bottom: $spacing-unit / 2;
   │                  ^^^^^^^^^^^^^^^^^
   ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 40:18           @import
    minima.scss 48:3                                                 @import
    /Users/aa/Repos/documentation/build/jekyll/assets/main.scss 1:9  root stylesheet
@aallan aallan added bug toolchain This is an infrastructure/toolchain issue labels Mar 2, 2023
@mudge
Copy link
Contributor

mudge commented Mar 2, 2023

See jekyll/minima#709

@aallan
Copy link
Contributor Author

aallan commented Mar 2, 2023

Thanks for the pointer @mudge

@lurch lurch added the dependencies Pull requests that update a dependency file label Mar 2, 2023
@nelliemckesson
Copy link
Contributor

@aallan given the contents of that thread Paul linked, would you be ok with just hiding those warnings until minima ships their next release?

@aallan
Copy link
Contributor Author

aallan commented Mar 14, 2023

@aallan given the contents of that thread Paul linked, would you be ok with just hiding those warnings until minima ships their next release?

Seems reasonable! 🤣

@nelliemckesson
Copy link
Contributor

This is temporarily handled by #2866 , but let's keep this issue open as a reminder to keep an eye on minima releases.

@aallan
Copy link
Contributor Author

aallan commented Mar 17, 2023

Merged #2866, but we'll keep this open for a proper fix later.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@lurch
Copy link
Contributor

lurch commented May 21, 2023

According to the issue @mudge linked to above, this hasn't been fixed in upstream yet.

@lurch lurch added backlog We'll be getting to it eventually and removed stale issue labels May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll be getting to it eventually bug dependencies Pull requests that update a dependency file toolchain This is an infrastructure/toolchain issue
Projects
None yet
Development

No branches or pull requests

4 participants