Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch1970: Access Point refactoring #1333

Merged
merged 89 commits into from
Apr 24, 2020
Merged

Epoch1970: Access Point refactoring #1333

merged 89 commits into from
Apr 24, 2020

Conversation

JamesH65
Copy link
Contributor

This is a merge from the original OP's branch, but still needs copy editing, so added as a new PR.

@lurch
Copy link
Contributor

lurch commented Jan 8, 2020

Many of the comments I've just made about access-point-bridged.md also apply to access-point-routed.md

@lurch
Copy link
Contributor

lurch commented Feb 3, 2020

On the off-chance that there are any external resources (e.g. user-written tutorials?) pointing to access-point.md, should we re-instate it with links to the two new pages?

@epoch1970
Copy link
Contributor

epoch1970 commented Mar 7, 2020

#1423 needs to be reopened. Or otherwise note the howto is confirmed broken. Something changed w/ systemd or dhcpcd and the instructions no longer work.
This is a blocking issue.
I am not very keen on wasting my life making systemd-networkd work personally.
EDIT. Some sort of progress over at #1423. Check it out.

Comment on lines +115 to +116
Interface `br0` will be configured in accordance with the defaults via DHCP; no specific entry is necessary. Save the file to complete the IP configuration of the machine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to the end of the file and add the following:

interface br0

With this line, interface br0 will be configured in accordance with the defaults via DHCP. Save the file to complete the IP configuration of the machine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's above is a proposed fix, as per #1423.
The routed ap howto already asked users to add something at the beginning of file dhcpcd.conf, and something else at the end of that same file. Now this seems necessary for the bridged ap as well.

@fikrikarim
Copy link

What a nice PR.

I found this PR after trying to set up an AP as a bridge on 3B+. I follow the guide on this PR, but somehow I got incorrect password everytime I tried to connect via Wi-Fi using my laptop or handphone. The problem is exactly similar to this one.

In the end I tried reflashing my PI, and follow the guide that I got from one of the answer there. Using that answer now everything is working so far.

I'm not sure what my problem was. Just want to share my experience here. Anyway this PR is needed because I think the one on the master branch is pretty old and need update.

@JamesH65
Copy link
Contributor Author

This has been hanging around for quite a while now - I am inclined to merge it (once rebased) since it's better than the current pages, even if not quite perfect.

@JamesH65
Copy link
Contributor Author

@epoch1970. Really sorry about the delay here. If you can rebase it to current tree then I'll give a last once over and merge it.

@epoch1970
Copy link
Contributor

No problem. However, you're speaking to a dummy: I don't understand what rebasing entails. What do you want me to do?

@JamesH65
Copy link
Contributor Author

There are apparently conflicts which prevent it from merging, so something has changed on our repothat means you PR won't apply. Rebasing really just means fixing it up so it will reapply without conflicts. ie rebasing you change on top on the new top of tree docs. On the command line I would "git pull --rebase upstream master" or similar then fix the conflicts, but not sure how you do that in github...Might be easier if I do it here. Will try!

@JamesH65 JamesH65 merged commit 10e24b2 into master Apr 24, 2020
@JamesH65
Copy link
Contributor Author

I think that has done it....

@epoch1970
Copy link
Contributor

Great!

JamesH65 pushed a commit that referenced this pull request Apr 24, 2020
As per a Mar. 7 comment I made on #1333 that didn't get included.
Declaring "interface br0" in dhcpcd.conf is mandatory I think. The dhcpcd.conf manpage says so, since br is a "virtual" interface. The original write-up worked without it, but no longer. Uncovered in #1423
@JamesH65 JamesH65 deleted the epoch1970-ap-refactor branch May 5, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants