Skip to content

Commit

Permalink
intel-iommu: Kill DMAR_BROKEN_GFX_WA option.
Browse files Browse the repository at this point in the history
Just make it depend on BROKEN for now, in case people scream really loud
about it (and because we might want to keep some of this logic for an
upcoming BIOS workaround, so I don't just want to rip it out entirely
just yet). But for graphics devices, it really ought to be unnecessary.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Sep 19, 2009
1 parent 64de5af commit 0c02a20
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions Documentation/Intel-IOMMU.txt
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -56,11 +56,7 @@ Graphics Problems?
------------------ ------------------
If you encounter issues with graphics devices, you can try adding If you encounter issues with graphics devices, you can try adding
option intel_iommu=igfx_off to turn off the integrated graphics engine. option intel_iommu=igfx_off to turn off the integrated graphics engine.

If this fixes anything, please ensure you file a bug reporting the problem.
If it happens to be a PCI device included in the INCLUDE_ALL Engine,
then try enabling CONFIG_DMAR_GFX_WA to setup a 1-1 map. We hear
graphics drivers may be in process of using DMA api's in the near
future and at that time this option can be yanked out.


Some exceptions to IOVA Some exceptions to IOVA
----------------------- -----------------------
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/Kconfig
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -1916,7 +1916,7 @@ config DMAR_DEFAULT_ON
config DMAR_BROKEN_GFX_WA config DMAR_BROKEN_GFX_WA
def_bool n def_bool n
prompt "Workaround broken graphics drivers (going away soon)" prompt "Workaround broken graphics drivers (going away soon)"
depends on DMAR depends on DMAR && BROKEN
---help--- ---help---
Current Graphics drivers tend to use physical address Current Graphics drivers tend to use physical address
for DMA and avoid using DMA APIs. Setting this config for DMA and avoid using DMA APIs. Setting this config
Expand Down

0 comments on commit 0c02a20

Please sign in to comment.