Skip to content

Commit

Permalink
staging: bcm2835-codec: Correct port width calc for truncation
Browse files Browse the repository at this point in the history
The calculation converting from V4L2 bytesperline to MMAL
width had an operator ordering issue that lead to Bayer raw 10
(and 12 and 14) setting an incorrect stride for the buffer.
Correct this operation ordering issue.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  • Loading branch information
6by9 authored and Phil Elwell committed May 28, 2019
1 parent 63555b0 commit 346a929
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -605,8 +605,8 @@ static void setup_mmal_port_format(struct bcm2835_codec_ctx *ctx,

if (!(q_data->fmt->flags & V4L2_FMT_FLAG_COMPRESSED)) {
/* Raw image format - set width/height */
port->es.video.width = q_data->bytesperline /
(q_data->fmt->depth >> 3);
port->es.video.width = (q_data->bytesperline << 3) /
q_data->fmt->depth;
port->es.video.height = q_data->height;
port->es.video.crop.width = q_data->crop_width;
port->es.video.crop.height = q_data->crop_height;
Expand Down

0 comments on commit 346a929

Please sign in to comment.