Skip to content

Commit

Permalink
imx708: Do not reset vblank to a default value
Browse files Browse the repository at this point in the history
imx708_set_framing_limits resets the vblank control to the mode default
value unconditionally. This causes it to overwrite the user specified
vblank and exposure control values when starting the sensor, since
it is called when handling V4L2_CID_WIDE_DYNAMIC_RANGE.

Remove this call to s_ctrl as it is unnecessary.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
  • Loading branch information
naushir authored and pelwell committed Jan 5, 2023
1 parent 5e09cee commit 355bbe0
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/media/i2c/imx708.c
Expand Up @@ -1041,9 +1041,6 @@ static void imx708_set_framing_limits(struct imx708 *imx708)
IMX708_FRAME_LENGTH_MAX - mode->height,
1, mode->vblank_default);

/* Setting this will adjust the exposure limits as well. */
__v4l2_ctrl_s_ctrl(imx708->vblank, mode->vblank_default);

/*
* Currently PPL is fixed to the mode specified value, so hblank
* depends on mode->width only, and is not changeable in any
Expand Down

0 comments on commit 355bbe0

Please sign in to comment.