Skip to content

Commit

Permalink
staging: bcm2835-camera: Fix open parenthesis alignment
Browse files Browse the repository at this point in the history
Fix checkpatch "Alignment should match open parenthesis"
errors.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  • Loading branch information
6by9 authored and Phil Elwell committed May 28, 2019
1 parent 2dfd809 commit 47870c2
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 20 deletions.
12 changes: 5 additions & 7 deletions drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
Expand Up @@ -412,8 +412,7 @@ static void buffer_cb(struct vchiq_mmal_instance *instance,
buf->vb.flags |= V4L2_BUF_FLAG_KEYFRAME;

v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
"Buffer has ts %llu",
dev->capture.last_timestamp);
"Buffer has ts %llu", dev->capture.last_timestamp);
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_DONE);

if (mmal_flags & MMAL_BUFFER_HEADER_FLAG_EOS &&
Expand Down Expand Up @@ -581,8 +580,8 @@ static int start_streaming(struct vb2_queue *vq, unsigned int count)
vchiq_mmal_port_enable(dev->instance, dev->capture.port, buffer_cb);
if (ret) {
v4l2_err(&dev->v4l2_dev,
"Failed to enable capture port - error %d. Disabling camera port again\n",
ret);
"Failed to enable capture port - error %d. Disabling camera port again\n",
ret);

vchiq_mmal_port_disable(dev->instance,
dev->capture.camera_port);
Expand Down Expand Up @@ -978,8 +977,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
f->fmt.pix.bytesperline =
(f->fmt.pix.bytesperline + align_mask) & ~align_mask;
v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
"Not removing padding, so bytes/line = %d, "
"(align_mask %d)\n",
"Not removing padding, so bytes/line = %d, (align_mask %d)\n",
f->fmt.pix.bytesperline, align_mask);
}

Expand Down Expand Up @@ -1325,7 +1323,7 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
}

static int vidioc_enum_framesizes(struct file *file, void *fh,
struct v4l2_frmsizeenum *fsize)
struct v4l2_frmsizeenum *fsize)
{
struct bm2835_mmal_dev *dev = video_drvdata(file);
static const struct v4l2_frmsize_stepwise sizes = {
Expand Down
25 changes: 16 additions & 9 deletions drivers/staging/vc04_services/bcm2835-camera/controls.c
Expand Up @@ -1254,9 +1254,12 @@ int bm2835_mmal_init_controls(struct bm2835_mmal_dev *dev,

switch (ctrl->type) {
case MMAL_CONTROL_TYPE_STD:
dev->ctrls[c] = v4l2_ctrl_new_std(hdl,
&bm2835_mmal_ctrl_ops, ctrl->id,
ctrl->min, ctrl->max, ctrl->step, ctrl->def);
dev->ctrls[c] =
v4l2_ctrl_new_std(hdl,
&bm2835_mmal_ctrl_ops,
ctrl->id, ctrl->min,
ctrl->max, ctrl->step,
ctrl->def);
break;

case MMAL_CONTROL_TYPE_STD_MENU:
Expand All @@ -1280,16 +1283,20 @@ int bm2835_mmal_init_controls(struct bm2835_mmal_dev *dev,
mask = ~mask;
}

dev->ctrls[c] = v4l2_ctrl_new_std_menu(hdl,
&bm2835_mmal_ctrl_ops, ctrl->id,
ctrl->max, mask, ctrl->def);
dev->ctrls[c] =
v4l2_ctrl_new_std_menu(hdl,
&bm2835_mmal_ctrl_ops,
ctrl->id, ctrl->max,
mask, ctrl->def);
break;
}

case MMAL_CONTROL_TYPE_INT_MENU:
dev->ctrls[c] = v4l2_ctrl_new_int_menu(hdl,
&bm2835_mmal_ctrl_ops, ctrl->id,
ctrl->max, ctrl->def, ctrl->imenu);
dev->ctrls[c] =
v4l2_ctrl_new_int_menu(hdl,
&bm2835_mmal_ctrl_ops,
ctrl->id, ctrl->max,
ctrl->def, ctrl->imenu);
break;

case MMAL_CONTROL_TYPE_CLUSTER:
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
Expand Up @@ -645,7 +645,7 @@ static int send_synchronous_mmal_msg(struct vchiq_mmal_instance *instance,
if (payload_len >
(MMAL_MSG_MAX_SIZE - sizeof(struct mmal_msg_header))) {
pr_err("payload length %d exceeds max:%d\n", payload_len,
(int)(MMAL_MSG_MAX_SIZE -
(int)(MMAL_MSG_MAX_SIZE -
sizeof(struct mmal_msg_header)));
return -EINVAL;
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h
Expand Up @@ -128,7 +128,7 @@ int vchiq_mmal_port_enable(
* disable a port will dequeue any pending buffers
*/
int vchiq_mmal_port_disable(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *port);
struct vchiq_mmal_port *port);

int vchiq_mmal_port_parameter_set(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *port,
Expand All @@ -146,8 +146,8 @@ int vchiq_mmal_port_set_format(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *port);

int vchiq_mmal_port_connect_tunnel(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *src,
struct vchiq_mmal_port *dst);
struct vchiq_mmal_port *src,
struct vchiq_mmal_port *dst);

int vchiq_mmal_version(struct vchiq_mmal_instance *instance,
u32 *major_out,
Expand Down

0 comments on commit 47870c2

Please sign in to comment.