Skip to content

Commit

Permalink
drm/vc4: Correct SAND support for FKMS.
Browse files Browse the repository at this point in the history
It was accepting NV21 which doesn't map through, but
also wasn't advertising the modifier so nothing would know
to request it.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  • Loading branch information
6by9 authored and Phil Elwell committed Jun 26, 2019
1 parent fabadd0 commit 47e85bc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/vc4/vc4_firmware_kms.c
Expand Up @@ -544,14 +544,14 @@ static bool vc4_fkms_format_mod_supported(struct drm_plane *plane,
return false;
}
case DRM_FORMAT_NV12:
case DRM_FORMAT_NV21:
switch (fourcc_mod_broadcom_mod(modifier)) {
case DRM_FORMAT_MOD_LINEAR:
case DRM_FORMAT_MOD_BROADCOM_SAND128:
return true;
default:
return false;
}
case DRM_FORMAT_NV21:
case DRM_FORMAT_RGB888:
case DRM_FORMAT_BGR888:
case DRM_FORMAT_YUV422:
Expand Down Expand Up @@ -598,6 +598,7 @@ static struct drm_plane *vc4_fkms_plane_init(struct drm_device *dev,
* would prefer to scan out linear (less bus traffic).
*/
DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED,
DRM_FORMAT_MOD_BROADCOM_SAND128,
DRM_FORMAT_MOD_INVALID,
};
int i;
Expand Down

0 comments on commit 47e85bc

Please sign in to comment.