Skip to content

Commit

Permalink
drm/vc4: Don't wait for vblank on fkms cursor updates.
Browse files Browse the repository at this point in the history
We don't use the same async update path between fkms and normal kms,
and the normal kms workaround ended up making us wait.  This became a
larger problem in rpi-4.14.y, as the USB HID update rate throttling
got (accidentally?) dropped.

Signed-off-by: Eric Anholt <eric@anholt.net>
  • Loading branch information
anholt authored and Phil Elwell committed Apr 16, 2019
1 parent d5a5dee commit 5aee83f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/vc4/vc4_kms.c
Expand Up @@ -220,7 +220,8 @@ static int vc4_atomic_commit(struct drm_device *dev,
* drm_atomic_helper_setup_commit() from auto-completing
* commit->flip_done.
*/
state->legacy_cursor_update = false;
if (!vc4->firmware_kms)
state->legacy_cursor_update = false;
ret = drm_atomic_helper_setup_commit(state, nonblock);
if (ret)
return ret;
Expand Down

0 comments on commit 5aee83f

Please sign in to comment.