Skip to content

Commit

Permalink
drm/vc4: Remove extra barrier()s aroudn CTnCA/CTnEA setup.
Browse files Browse the repository at this point in the history
The writel() that these expand to already does barriers.

Signed-off-by: Eric Anholt <eric@anholt.net>
  • Loading branch information
anholt authored and Phil Elwell committed Dec 2, 2015
1 parent d043937 commit 85b59fe
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/gpu/drm/vc4/vc4_gem.c
Expand Up @@ -104,14 +104,11 @@ submit_cl(struct drm_device *dev, uint32_t thread, uint32_t start, uint32_t end)
{
struct vc4_dev *vc4 = to_vc4_dev(dev);

V3D_WRITE(V3D_CTNCA(thread), start);
barrier();

/* Set the end address of the control list. Writing this
* register is what starts the job.
/* Set the current and end address of the control list.
* Writing the end register is what starts the job.
*/
V3D_WRITE(V3D_CTNCA(thread), start);
V3D_WRITE(V3D_CTNEA(thread), end);
barrier();
}

int
Expand Down

0 comments on commit 85b59fe

Please sign in to comment.