Skip to content

Commit

Permalink
staging: vc-sm-cma: Don't fail if debugfs calls fail.
Browse files Browse the repository at this point in the history
Return codes from debugfs calls should never alter the
flow of the main code.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  • Loading branch information
6by9 authored and Phil Elwell committed May 28, 2019
1 parent 8652e3e commit c576e81
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/staging/vc04_services/vc-sm-cma/vc_sm.c
Expand Up @@ -681,13 +681,6 @@ static void vc_sm_connected_init(void)

/* Create a debug fs directory entry (root). */
sm_state->dir_root = debugfs_create_dir(VC_SM_DIR_ROOT_NAME, NULL);
if (!sm_state->dir_root) {
pr_err("[%s]: failed to create \'%s\' directory entry\n",
__func__, VC_SM_DIR_ROOT_NAME);

ret = -EPERM;
goto err_stop_sm_service;
}

sm_state->dir_state.show = &vc_sm_cma_global_state_show;
sm_state->dir_state.dir_entry =
Expand Down Expand Up @@ -720,7 +713,6 @@ static void vc_sm_connected_init(void)

err_remove_shared_memory:
debugfs_remove_recursive(sm_state->dir_root);
err_stop_sm_service:
vc_sm_cma_vchi_stop(&sm_state->sm_handle);
err_failed:
pr_info("[%s]: failed, ret %d\n", __func__, ret);
Expand Down

0 comments on commit c576e81

Please sign in to comment.