Skip to content

Commit

Permalink
bcm2708_fb: Fix layout of struct vc4_display_settings_t
Browse files Browse the repository at this point in the history
The display parameters returned by the VC4 firmware in response to the
RPI_FIRMWARE_FRAMEBUFFER_GET_DISPLAY_SETTINGS tag do not match the
layout of struct vc4_display_settings_t: the colour depth and row
pitch are erroneously swapped in the kernel definition.  This can
trigger a kernel warning from pixel_to_pat(), such as:

  pixel_to_pat(): unsupported pixelformat 7296

Fix by adjusting the layout of struct vc4_display_settings_t to match
the layout as used by the VC4 firmware.

Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
  • Loading branch information
mcb30 authored and Phil Elwell committed Sep 30, 2019
1 parent a6b6319 commit d378674
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/bcm2708_fb.c
Expand Up @@ -88,8 +88,8 @@ struct vc4_display_settings_t {
u32 display_num;
u32 width;
u32 height;
u32 pitch;
u32 depth;
u32 pitch;
u32 virtual_width;
u32 virtual_height;
u32 virtual_width_offset;
Expand Down

0 comments on commit d378674

Please sign in to comment.