Skip to content

Commit

Permalink
drm/v3d: Suppress all but the first MMU error
Browse files Browse the repository at this point in the history
The v3d driver currently encounters a lot of MMU PTE exceptions, so
only log the first to avoid swamping the kernel log.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
  • Loading branch information
Phil Elwell authored and popcornmix committed Jul 13, 2020
1 parent 0fc39c8 commit f23e93b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/v3d/v3d_irq.c
Expand Up @@ -177,6 +177,7 @@ v3d_hub_irq(int irq, void *arg)
"GMP",
};
const char *client = "?";
static int logged_error;

V3D_WRITE(V3D_MMU_CTL, V3D_READ(V3D_MMU_CTL));

Expand All @@ -186,6 +187,7 @@ v3d_hub_irq(int irq, void *arg)
client = v3d41_axi_ids[axi_id];
}

if (!logged_error)
dev_err(v3d->dev, "MMU error from client %s (%d) at 0x%llx%s%s%s\n",
client, axi_id, (long long)vio_addr,
((intsts & V3D_HUB_INT_MMU_WRV) ?
Expand All @@ -194,6 +196,7 @@ v3d_hub_irq(int irq, void *arg)
", pte invalid" : ""),
((intsts & V3D_HUB_INT_MMU_CAP) ?
", cap exceeded" : ""));
logged_error = 1;
status = IRQ_HANDLED;
}

Expand Down

0 comments on commit f23e93b

Please sign in to comment.