Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpio-poweroff dt overlay also switches pin when "halt --halt" is executed #1600

Closed
MaxValue opened this issue Aug 16, 2016 · 3 comments
Closed

Comments

@MaxValue
Copy link

In #1031 an optional feature (gpio-poweroff device tree overlay) was introduced to mimic the poweroff behaviour of standard desktop computers: If the system is being powered off, also the power supply will be "detached" - the LEDs are off. This is like making an ACPI call to the power supply unit.

So first of all, in the documentation of gpio-poweroff (overlays README file) it is written:

Info: Drives a GPIO high or low on reboot

This is clearly not correct, because this feature only activates on poweroff (not reboot), right?

And now for the real issue: The feature also activates on halt - eg. only the software is completely stopped, but the hardware still has power. Test it yourself with shutdown --halt now or halt --halt or systemctl halt.
Is this maybe intended?

I searched for similar issues and only found the citation of this bugfix, but i am not sure if this is related.

Maybe i am just understanding the behaviour of "halting a system" differently here, if so please tell me too.

Thanks a lot in advantage!

@pelwell
Copy link
Contributor

pelwell commented Aug 22, 2016

The reference to "reboot" in the README is sloppy use of language - we'll correct it.

The standard halt behaviour on 32-bit ARMs is to disable interrupts and leave the CPUs spinning. The RPi branches have a patch (3ce05d6) that makes halt equivalent to poweroff. This was to reduce power consumption and heat in what should be a low-power mode, so the change was intentional.

If you can explain why would you want to halt without powering off then we can consider whether it is worth reinvestigating.

@MaxValue
Copy link
Author

Thank you for reading my issue!
I wanted to point out the halt-behaviour, because i learned "If you see a bug, report it.". Also it kind of shook my beliefs about shutdown-behaviour in general.

For me it is no real problem, i just thought that this information might be useful to this project. I dunno.

pelwell pushed a commit that referenced this issue Aug 22, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
@pelwell
Copy link
Contributor

pelwell commented Aug 22, 2016

OK, for now I will say "This behaviour is by design" (at least for RPi kernels). I've added a note to the README to this effect. If this proves to be a problem for users then we can revisit the issue.

@pelwell pelwell closed this as completed Aug 22, 2016
popcornmix pushed a commit that referenced this issue Aug 23, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 3, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 5, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 7, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 7, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 7, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
grgbr pushed a commit to grgbr/linux-iio that referenced this issue Sep 13, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
popcornmix pushed a commit that referenced this issue Sep 14, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 15, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 19, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 24, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 29, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Sep 30, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Oct 3, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Oct 9, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Oct 17, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
popcornmix pushed a commit that referenced this issue Oct 22, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: #1600
ColinIanKing pushed a commit to ColinIanKing/ubuntu-xenial that referenced this issue Oct 28, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
angyalp pushed a commit to angyalp/kernel_rpi that referenced this issue Dec 19, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi#1600
tabp0le pushed a commit to tabp0le/ubuntu_xenial_kernel that referenced this issue Dec 22, 2016
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
Captain-DarkO pushed a commit to Captain-DarkO/kernel_ubuntu-yakkety that referenced this issue Jan 20, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
perfecto-devops pushed a commit to perfecto-devops/ubuntu-xenial that referenced this issue Feb 2, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
Noltari pushed a commit to Noltari/linux that referenced this issue Feb 6, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
artynet pushed a commit to artynet/ubuntu-yakkety-kernel that referenced this issue Feb 15, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
JackieLiu1 pushed a commit to JackieLiu1/kernel that referenced this issue Mar 23, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
woshihuangzhijie pushed a commit to woshihuangzhijie/linuxcode that referenced this issue Sep 20, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
amichelotti pushed a commit to amichelotti/ubuntu-vme-xenial that referenced this issue Oct 19, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
lianhaidong pushed a commit to lianhaidong/ubuntu-xenial that referenced this issue Nov 6, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
liuqun pushed a commit to liuqun/linux-raspi2 that referenced this issue Dec 14, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
liuqun pushed a commit to liuqun/linux-raspi2 that referenced this issue Dec 20, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
liuqun pushed a commit to liuqun/linux-raspi2 that referenced this issue Dec 20, 2017
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
polceanum pushed a commit to polceanum/ubuntu-xenial that referenced this issue Feb 6, 2018
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
APokorny pushed a commit to ubports/ubuntu_kernel_xenial that referenced this issue Oct 11, 2018
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
hisenyiu2015 pushed a commit to hisenyiu2015/msm-4.14 that referenced this issue May 20, 2021
1) GPIO pin is signalled on poweroff, not reboot.
2) In RPi kernels, halt is equivalent to poweroff.

See: raspberrypi/linux#1600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants