Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mic Bias to linux/sound/soc/codecs/wm8753.c #1829

Closed
charlton91 opened this issue Feb 6, 2017 · 3 comments
Closed

Add Mic Bias to linux/sound/soc/codecs/wm8753.c #1829

charlton91 opened this issue Feb 6, 2017 · 3 comments

Comments

@charlton91
Copy link

Currently there is no option in this driver to enable the microphone biasing circuit for the WM8753.

The following should be added to as an item in the struct wm8753_snd_controls in order to enable the mic bias circuit.

SOC_SINGLE("Mic Bias", WM8753_PWR1, 5, 1, 0),

@popcornmix
Copy link
Collaborator

This looks like an upstream kernel change. As such it should be submitted upstream:
https://kernel.org/doc/html/latest/process/submitting-patches.html

Assuming it is accepted upstream we can cherry-pick it.

@HiassofT
Copy link
Contributor

HiassofT commented Feb 6, 2017

micbias is usually controlled via DAPM, and the WM8753 already contains the necessary dapm widgets - you only have to define the routes in your machine driver - i.e. connect the MICBIAS widget to your input widget.

See for example the dapm routes in my Cirrus card driver in PR #1810

@JamesH65
Copy link
Contributor

Closing this issue as questions answered/issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants