Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2c-rtc-overlay, __overrides__ in wrong order #2059

Closed
oliskoli opened this issue Jun 6, 2017 · 3 comments
Closed

i2c-rtc-overlay, __overrides__ in wrong order #2059

oliskoli opened this issue Jun 6, 2017 · 3 comments

Comments

@oliskoli
Copy link

oliskoli commented Jun 6, 2017 •
edited by pelwell

Current version activates mcp7940x when using overlay parameter ds3231.

diff --git a/arch/arm/boot/dts/overlays/i2c-rtc-overlay.dts b/arch/arm/boot/dts/overlays/i2c-rtc-overlay.dts
index b73f902289c8..1b2328ebc577 100644
--- a/arch/arm/boot/dts/overlays/i2c-rtc-overlay.dts
+++ b/arch/arm/boot/dts/overlays/i2c-rtc-overlay.dts
@@ -147,9 +147,9 @@
                abx80x = <0>,"+0";
                ds1307 = <0>,"+1";
                ds1339 = <0>,"+2";
-               ds3231 = <0>,"+3";
-               mcp7940x = <0>,"+4";
-               mcp7941x = <0>,"+5";
+               mcp7940x = <0>,"+3";
+               mcp7941x = <0>,"+4";
+               ds3231 = <0>,"+5";
                pcf2127 = <0>,"+6";
                pcf8523 = <0>,"+7";
                pcf8563 = <0>,"+8";
pelwell pushed a commit that referenced this issue Jun 7, 2017
overlays: Fix i2c-rtc order and fragment numbering
8760343 
See: #2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Contributor

pelwell commented Jun 7, 2017

It's a fair cop - sorry about that. I'll add some automated testing for these container overlays.

@pelwell
Copy link
Contributor

pelwell commented Jun 7, 2017

The fix will be in the next firmware release, but in the meantime you can download an updated dtbo here: https://drive.google.com/open?id=0B_P-i4u-SLBXN240NEVJUmZXak0

@oliskoli
Copy link
Author

oliskoli commented Jun 7, 2017

thanks for quick response

@oliskoli oliskoli closed this as completed Jun 7, 2017
popcornmix added a commit to raspberrypi/firmware that referenced this issue Jun 8, 2017
@popcornmix
kernel: Bump to 4.9.31
ca9116f 
kernel: dwc_otg: make periodic scheduling behave properly for FS buses
See: raspberrypi/linux#2038

kernel: dwc_otg: fiq_fsm: Make isochronous compatibility checks work properly
See: raspberrypi/linux#2049

kernel: Add support for Allo Digione Driver
See: raspberrypi/linux#2048

kernel: config: Adding SENSOR_JC42
See: raspberrypi/linux#2046

kernel: BCM270X_DT: Improve i2c-sensor and i2c-rtc overlay
kernel: overlays: Fix i2c-rtc order and fragment numbering
See: raspberrypi/linux#2059

kernel: BCM270X_DT: Add midi-uart1 overlay
See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=183860

firmware: dtoverlay: Short-circuit empty parameter handling
See: raspberrypi/linux#2028

firmware: rtos: Protect against null timer callback
See: http://forum.kodi.tv/showthread.php?tid=280408

firmware: arm_dt: Add txp node to device tree parsing to mask off transposer interrupt

firmware: venc: Correct the validation on custom mb/mbps/br settings
See: #819
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Jun 8, 2017
@popcornmix
kernel: Bump to 4.9.31
9e6a1a5 
kernel: dwc_otg: make periodic scheduling behave properly for FS buses
See: raspberrypi/linux#2038

kernel: dwc_otg: fiq_fsm: Make isochronous compatibility checks work properly
See: raspberrypi/linux#2049

kernel: Add support for Allo Digione Driver
See: raspberrypi/linux#2048

kernel: config: Adding SENSOR_JC42
See: raspberrypi/linux#2046

kernel: BCM270X_DT: Improve i2c-sensor and i2c-rtc overlay
kernel: overlays: Fix i2c-rtc order and fragment numbering
See: raspberrypi/linux#2059

kernel: BCM270X_DT: Add midi-uart1 overlay
See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=183860

firmware: dtoverlay: Short-circuit empty parameter handling
See: raspberrypi/linux#2028

firmware: rtos: Protect against null timer callback
See: http://forum.kodi.tv/showthread.php?tid=280408

firmware: arm_dt: Add txp node to device tree parsing to mask off transposer interrupt

firmware: venc: Correct the validation on custom mb/mbps/br settings
See: raspberrypi/firmware#819
popcornmix pushed a commit that referenced this issue Jul 12, 2017
@popcornmix
overlays: Fix i2c-rtc order and fragment numbering
9937b5c 
See: #2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Aug 10, 2017
@popcornmix
overlays: Fix i2c-rtc order and fragment numbering
9a85b74 
See: #2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Aug 13, 2017
@popcornmix
overlays: Fix i2c-rtc order and fragment numbering
a0600ed 
See: #2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Oct 29, 2017
@popcornmix
overlays: Fix i2c-rtc order and fragment numbering
b4ddca9 
See: #2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this issue Nov 2, 2017
@raspbian-autopush
rpi_1283_3dcacfdeccd4c0454a72dc6a47881cbdbc589a55
366232c 
commit 3dcacfd
Author: Phil Elwell <phil@raspberrypi.org>
Date:   Wed Jun 7 08:53:36 2017 +0100

    overlays: Fix i2c-rtc order and fragment numbering
    
    See: raspberrypi/linux#2059
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1283_3dcacfdeccd4c0454a72dc6a47881cbdbc589a55.patch
ryncsn pushed a commit to ryncsn/linux-rasp that referenced this issue Nov 21, 2017
@ryncsn
overlays: Fix i2c-rtc order and fragment numbering
50097f1 
See: raspberrypi#2059

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this issue Apr 7, 2018
rpi_1285_668db2eb62f224267b382d8d8d68cacb9915f559
4856026 
commit 668db2e
Author: Phil Elwell <phil@raspberrypi.org>
Date:   Wed Jun 7 08:53:36 2017 +0100

    overlays: Fix i2c-rtc order and fragment numbering
    
    See: raspberrypi/linux#2059
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1285_668db2eb62f224267b382d8d8d68cacb9915f559.patch
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this issue Nov 11, 2018
@raspbian-autopush
rpi_1285_668db2eb62f224267b382d8d8d68cacb9915f559
c8f3794 
commit 668db2e
Author: Phil Elwell <phil@raspberrypi.org>
Date:   Wed Jun 7 08:53:36 2017 +0100

    overlays: Fix i2c-rtc order and fragment numbering
    
    See: raspberrypi/linux#2059
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1285_668db2eb62f224267b382d8d8d68cacb9915f559.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pelwell @oliskoli