Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"buggy DT: spidev listed directly in DT" warning is back again in latest kernel. #3361

Closed
trejan opened this issue Nov 30, 2019 · 2 comments
Closed

"buggy DT: spidev listed directly in DT" warning is back again in latest kernel. #3361

trejan opened this issue Nov 30, 2019 · 2 comments

Comments

@trejan
Copy link

trejan commented Nov 30, 2019 •
edited

The "buggy DT: spidev listed directly in DT" warning is back again in the latest kernel (4.19.86-v7l+ #1283 SMP Fri Nov 29 18:37:40 GMT 2019) that was originally patched in #1054 due to the e616dd6

[    7.217014] ------------[ cut here ]------------
[    7.217050] WARNING: CPU: 1 PID: 266 at drivers/spi/spidev.c:730 spidev_probe+0x100/0x1a8 [spidev]
[    7.217065] /soc/spi@7e204000/spidev@0: buggy DT: spidev listed directly in DT
[    7.217076] Modules linked in: spidev(+) pl2303 usbserial sg vc4 drm_kms_helper v3d gpu_sched bcm2835_codec(C) snd_soc_core bcm2835_v4l2(C) v4l2_mem2mem bcm2835_mmal_vchiq(C) raspberrypi_hwmon videobuf2_dma_contig hwmon v4l2_common snd_bcm2835(C) videobuf2_vmalloc videobuf2_memops snd_compress videobuf2_v4l2 drm snd_pcm_dmaengine videobuf2_common syscopyarea snd_pcm sysfillrect videodev sysimgblt fb_sys_fops drm_panel_orientation_quirks snd_timer snd media i2c_bcm2835 vc_sm_cma(C) spi_bcm2835 rpivid_mem uio_pdrv_genirq uio fixed i2c_dev ip_tables x_tables ipv6
[    7.217529] CPU: 1 PID: 266 Comm: modprobe Tainted: G         C        4.19.86-v7l+ #1283
[    7.217540] Hardware name: BCM2835
[    7.217582] [<c0212e04>] (unwind_backtrace) from [<c020d5e0>] (show_stack+0x20/0x24)
[    7.217608] [<c020d5e0>] (show_stack) from [<c09af1c8>] (dump_stack+0xe0/0x124)
[    7.217640] [<c09af1c8>] (dump_stack) from [<c0222564>] (__warn+0x104/0x11c)
[    7.217659] [<c0222564>] (__warn) from [<c02225d4>] (warn_slowpath_fmt+0x58/0x74)
[    7.217687] [<c02225d4>] (warn_slowpath_fmt) from [<bf54427c>] (spidev_probe+0x100/0x1a8 [spidev])
[    7.217754] [<bf54427c>] (spidev_probe [spidev]) from [<c0756700>] (spi_drv_probe+0x88/0xb4)
[    7.217787] [<c0756700>] (spi_drv_probe) from [<c0706eb4>] (really_probe+0x23c/0x2d4)
[    7.217821] [<c0706eb4>] (really_probe) from [<c0707120>] (driver_probe_device+0x70/0x1ac)
[    7.217841] [<c0707120>] (driver_probe_device) from [<c070734c>] (__driver_attach+0xf0/0xf4)
[    7.217859] [<c070734c>] (__driver_attach) from [<c0704be4>] (bus_for_each_dev+0x78/0xc4)
[    7.217876] [<c0704be4>] (bus_for_each_dev) from [<c0706788>] (driver_attach+0x2c/0x30)
[    7.217894] [<c0706788>] (driver_attach) from [<c0706174>] (bus_add_driver+0x1ac/0x224)
[    7.217914] [<c0706174>] (bus_add_driver) from [<c0707b38>] (driver_register+0x8c/0x124)
[    7.217933] [<c0707b38>] (driver_register) from [<c0756630>] (__spi_register_driver+0x68/0x6c)
[    7.217957] [<c0756630>] (__spi_register_driver) from [<bf54a0a4>] (spidev_init+0xa4/0x1000 [spidev])
[    7.217987] [<bf54a0a4>] (spidev_init [spidev]) from [<c020312c>] (do_one_initcall+0x50/0x218)
[    7.218009] [<c020312c>] (do_one_initcall) from [<c02bca28>] (do_init_module+0x74/0x220)
[    7.218029] [<c02bca28>] (do_init_module) from [<c02bb9a0>] (load_module+0x1dc0/0x2404)
[    7.218048] [<c02bb9a0>] (load_module) from [<c02bc200>] (sys_finit_module+0xbc/0xcc)
[    7.218065] [<c02bc200>] (sys_finit_module) from [<c02011a4>] (__sys_trace_return+0x0/0x1c)
[    7.218075] Exception stack(0xdb54dfa8 to 0xdb54dff0)
[    7.218087] dfa0:                   690ccd00 011ab6b0 00000003 0002d064 00000000 0002ec3c
[    7.218100] dfc0: 690ccd00 011ab6b0 00000000 0000017b 011ad160 00000000 011ab1a8 00000000
[    7.218110] dfe0: bee239b8 bee239a8 00022cb8 b6ce4af0
[    7.218120] ---[ end trace bf8db60aa9dcd413 ]---
[    7.218519] ------------[ cut here ]------------
@pelwell
Copy link
Contributor

pelwell commented Nov 30, 2019

Yeah, I spotted that yesterday while in the middle of something else. I don't agree with the upstream view of how spidev should be used, so I'll keep on disabling the warning.

pelwell pushed a commit that referenced this issue Dec 2, 2019
spidev: Completely disable the DT warning
a535fff 
The upstream SPI and DT maintainers are completely opposed to declaring
in Device Tree that an SPI CS line is to be managed by the spidev
driver, even though the facility is useful on a hobbyist device like a
Raspberry Pi where arbitrary devices can be attached, and the
alternative to DT declaration (spi_board_info) has been almost entirely
rendered obsolete by DT.

Continue to override their objections by disabling the warning.

See: #3361
     #1054

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Contributor

pelwell commented Dec 2, 2019

The warning is suppressed again - see a535fff.

@trejan trejan closed this as completed Dec 2, 2019
KonstaT pushed a commit to lineage-rpi/android_kernel_brcm_rpi3 that referenced this issue Dec 13, 2019
@KonstaT
spidev: Completely disable the DT warning
ed314bd 
The upstream SPI and DT maintainers are completely opposed to declaring
in Device Tree that an SPI CS line is to be managed by the spidev
driver, even though the facility is useful on a hobbyist device like a
Raspberry Pi where arbitrary devices can be attached, and the
alternative to DT declaration (spi_board_info) has been almost entirely
rendered obsolete by DT.

Continue to override their objections by disabling the warning.

See: raspberrypi/linux#3361
     raspberrypi/linux#1054

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
margro pushed a commit to margro/linux that referenced this issue Jan 18, 2020
@margro
spidev: Completely disable the DT warning
db151ba 
The upstream SPI and DT maintainers are completely opposed to declaring
in Device Tree that an SPI CS line is to be managed by the spidev
driver, even though the facility is useful on a hobbyist device like a
Raspberry Pi where arbitrary devices can be attached, and the
alternative to DT declaration (spi_board_info) has been almost entirely
rendered obsolete by DT.

Continue to override their objections by disabling the warning.

See: raspberrypi#3361
     raspberrypi#1054

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trejan @pelwell