Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB Gadget only mode is broken: struct dwc2_hsotg has no member named bus_suspended #4368

Open
pmunts opened this issue May 28, 2021 · 2 comments
Open

USB Gadget only mode is broken: struct dwc2_hsotg has no member named bus_suspended #4368

pmunts opened this issue May 28, 2021 · 2 comments

Comments

@pmunts
Copy link

pmunts commented May 28, 2021

One of the recent changes to the dwc2 driver has broken USB Gadget Only mode (CONFIG_USB_DWC2_PERIPHERAL=y).

The bus_suspended field of struct dwc2_hsotg is not included in the structure definition if CONFIG_USB_DWC2_PERIPHERAL is defined. This causes a compile error:

drivers/usb/dwc2/core_intr.c: In function 'dwc_handle_gpwrdn_disc_det':
drivers/usb/dwc2/core_intr.c:710:7: error: 'struct dwc2_hsotg' has no member named 'bus_suspended'
pelwell added a commit that referenced this issue May 28, 2021
@pelwell
usb: dwc2: Fix build in periphal-only mode
5f69d93 
The bus_suspended member of struct dwc2_hsotg is only present in builds
that support host-mode.

See: #4368

Fixes: 62bb46f ("usb: dwc2: Fix hibernation between host and device modes.")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented May 28, 2021

That's an upstream bug introduced by a recent fix (which is why it was back-ported). I've pushed a patch to rpi-5.10.y that should fix it.

@pelwell
Copy link
Contributor

pelwell commented May 28, 2021

https://marc.info/?l=linux-usb&m=162218990901875&w=2

pelwell added a commit that referenced this issue Jun 3, 2021
@pelwell
usb: dwc2: Fix build in periphal-only mode
69050b3 
The bus_suspended member of struct dwc2_hsotg is only present in builds
that support host-mode.

See: #4368

Fixes: 62bb46f ("usb: dwc2: Fix hibernation between host and device modes.")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Jun 3, 2021
@pelwell
usb: dwc2: Fix build in periphal-only mode
1b052ee 
The bus_suspended member of struct dwc2_hsotg is only present in builds
that support host-mode.

See: #4368

Fixes: 62bb46f ("usb: dwc2: Fix hibernation between host and device modes.")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 8, 2021
@pelwell @popcornmix
usb: dwc2: Fix build in periphal-only mode
3d8948d 
The bus_suspended member of struct dwc2_hsotg is only present in builds
that support host-mode.

See: #4368

Fixes: 62bb46f ("usb: dwc2: Fix hibernation between host and device modes.")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix added a commit to raspberrypi/firmware that referenced this issue Jun 8, 2021
@popcornmix
kernel: Bump to 5.10.42
afdb60c 
kernel: Add device tree overlay for ssd1331-spi screen
See: raspberrypi/linux#4372

kernel: drm/vc4: FKMS: Change of Broadcast RGB mode needs a mode change
See: raspberrypi/linux#4356

kernel: PoE HAT Plus support
See: raspberrypi/linux#4367

kernel: usb: dwc2: Fix build in periphal-only mode
See: raspberrypi/linux#4368

kernel: Add bh1750 light sensor ccs811 air quality sensor to i2c-sensor overlay
See: raspberrypi/linux#4334

firmware: PoE+ HAT support
See: raspberrypi/linux#4367

firmware: arm_loader: Use Pi4 bootloader MAC_ADDRESS if set

firmware: platform: Apply ARM thermal throttling rules on BCM2711
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Jun 8, 2021
@popcornmix
kernel: Bump to 5.10.42
6263bdf 
kernel: Add device tree overlay for ssd1331-spi screen
See: raspberrypi/linux#4372

kernel: drm/vc4: FKMS: Change of Broadcast RGB mode needs a mode change
See: raspberrypi/linux#4356

kernel: PoE HAT Plus support
See: raspberrypi/linux#4367

kernel: usb: dwc2: Fix build in periphal-only mode
See: raspberrypi/linux#4368

kernel: Add bh1750 light sensor ccs811 air quality sensor to i2c-sensor overlay
See: raspberrypi/linux#4334

firmware: PoE+ HAT support
See: raspberrypi/linux#4367

firmware: arm_loader: Use Pi4 bootloader MAC_ADDRESS if set

firmware: platform: Apply ARM thermal throttling rules on BCM2711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pelwell @pmunts