Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel Option CONFIG_SND_SOC_WM8960 Not Set #4454

Closed
hftsai256 opened this issue Jul 14, 2021 · 4 comments
Closed

Kernel Option CONFIG_SND_SOC_WM8960 Not Set #4454

hftsai256 opened this issue Jul 14, 2021 · 4 comments

Comments

@hftsai256
Copy link

In PR#4039, wm8960-soundcard overlay was added to the tree. However the correspond kernel module option was not enabled by that time. Therefore, when I'm building kernel for raspberry pi zero, I have:

armbuilder:~/wm8960/linux/rpi-5.4.y$make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- bcmrpi_defconfig
#
# configuration written to .config
#
armbuilder:~/wm8960/linux/rpi-5.4.y$ grep CONFIG_SND_SOC_WM8960 .config
# CONFIG_SND_SOC_WM8960 is not set

And therefore the required kernel module is missing. Are we expecting the option to be CONFIG_SND_SOC_WM8960=m in bcm{2709|2711|2835|rpi}_defconfig?

@pelwell
Copy link
Contributor

pelwell commented Jul 14, 2021

@shawaj How have you been using the overlay, since the codec driver is not enabled in our defconfigs?

pelwell added a commit that referenced this issue Jul 16, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Jul 16, 2021

The required config setting is now in our defconfigs, and the module will be in future kernel builds.

@hftsai256
Copy link
Author

Thanks @pelwell. May I ask a favor to merge this fix to kernel version 5.4.y? Would this bump the kernel version from 5.4.83+ to a larger y value?

pelwell added a commit that referenced this issue Jul 18, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Jul 18, 2021

It's in the 5.4 branch - see ec0dcf3. The version is still 5.4.83+, but it will get bumped when the next batch of upstream patches are applied.

popcornmix added a commit to raspberrypi/firmware that referenced this issue Jul 19, 2021
kernel: configs: Add SND_SOC_WM8960=m
See: raspberrypi/linux#4454

firmware: Revert: video_decode: Use the ISP instead of vc_image_convert
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Jul 19, 2021
kernel: configs: Add SND_SOC_WM8960=m
See: raspberrypi/linux#4454

firmware: Revert: video_decode: Use the ISP instead of vc_image_convert
@pelwell pelwell closed this as completed Jul 21, 2021
pelwell added a commit that referenced this issue Jul 23, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Jul 23, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Jul 26, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Jul 27, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 27, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 27, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 27, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Jul 29, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 11, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 11, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Noltari pushed a commit to Noltari/rpi-linux that referenced this issue Aug 20, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: raspberrypi#4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 21, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 21, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Sep 8, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Sep 8, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Sep 15, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Sep 15, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
mripard pushed a commit to mripard/rpi-linux that referenced this issue Sep 16, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: raspberrypi#4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Sep 30, 2021
Enable the WM8960 driver module, as used by the wm8960-soundcard
overlay.

See: #4454

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants